Repository navigation
Release ti ticura 0.1.0 - #19280
Release ti ticura 0.1.0#19280
Conversation
ReviewersBuildkite won't run for external contributors automatically; you need to add a comment:
NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details. |
|
@efd6 @andrewkroh @jsoriano Hi team, I’d love to get your feedback when you have a chance. |
|
/test |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Elastic Docs Style Checker (Vale)Summary: 8 warnings, 3 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/ti_ticura/_dev/build/docs/README.md | 5 | Elastic.EndPuntuaction | Don't end headings with punctuation. |
| packages/ti_ticura/_dev/build/docs/README.md | 100 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/ti_ticura/_dev/build/docs/README.md | 100 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/ti_ticura/_dev/build/docs/README.md | 100 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/ti_ticura/_dev/build/docs/README.md | 169 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/ti_ticura/_dev/build/docs/README.md | 188 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/ti_ticura/_dev/build/docs/README.md | 246 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'versus' instead of 'vs'. |
| packages/ti_ticura/_dev/build/docs/README.md | 318 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
💡 Suggestions (3): Optional style improvements. Apply when helpful.
| File | Line | Rule | Message |
|---|---|---|---|
| packages/ti_ticura/_dev/build/docs/README.md | 154 | Elastic.Wordiness | Consider using 'all' instead of 'All of '. |
| packages/ti_ticura/_dev/build/docs/README.md | 377 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/ti_ticura/changelog.yml | 1 | Elastic.Versions | Use 'later versions' instead of 'newer versions' when referring to versions. |
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@kcreddy Handled findings / comments. Please re-test. |
|
/test |
|
/test |
|
@kcreddy I had to remove outdated rules that caused failed pipeline. Please re-test |
|
/test |
|
@kcreddy got it. thank you for all the support. just removed the agentless code and doku. |
|
👀 I have started reviewing the PR |
|
/test |
kcreddy
left a comment
There was a problem hiding this comment.
Can you add this section to your README as well?
Once you run elastic-package build this will be rendered inside docs/README with your mapped fields and sample_event.json. Integration docs will look like this: https://www.elastic.co/docs/reference/integrations/ti_threatconnect#logs-reference
|
@kcreddy extended readme as requested and rebuild the sample json. lets see if we're good to go now. |
|
👀 I have started reviewing the PR |
|
/test |
|
👀 I have started reviewing the PR |
|
👀 I have started reviewing the PR |
Vera Review BotFor the current commit state, I did not find any issues. 🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
|
@kcreddy anything else we could do to proceed here? :-) |
|
/test |
|
✅ All changelog entries have the correct PR link. |
|
👀 I have started reviewing the PR |
💚 Build Succeeded
History
|
Vera Review BotFor the current commit state, I did not find any issues. 🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
kcreddy
left a comment
There was a problem hiding this comment.
LGTM. @eduardenes-ticura, thanks for much for the patience and addressing all the review comments.
|
Tick the box to add this pull request to the merge queue (same as
|
|
Package ti_ticura - 0.1.0 containing this change is available at https://epr.elastic.co/package/ti_ticura/0.1.0/ |
Initial release of the
ti_ticuraintegration (version 0.1.0)ti_ticuraintegration with all required assets, including pipelines, data streams, rules, searches, dashboards, and fields. This is the first release of this integration.ti_ticuraintegration available to users via the Elastic Package Registry.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
elastic-package checkin the integration directoryelastic-package stack up -dandelastic-package installHow to verify end-to-end against the live Ticura API:
Related issues
Screenshots